Fix missing HandleScope in callback #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-taylor
added a commit
to phil-taylor/nreports
that referenced
this pull request
Nov 23, 2015
|
This patch seems to indeed fix the issue. I hope it's merged in soon :) |
|
@TooTallNate Please merge & release, if appropriate. Otherwise, there are issues getting Node 5.x to prod when used for SEO prerendering. |
TooTallNate
added a commit
that referenced
this pull request
Jan 4, 2016
Fix missing HandleScope in callback
|
Published in v1.0.1. Thanks! |
This was referenced Jan 4, 2016
Closed
|
I can confirm. Now, prerender.io is working on Node v5.3 with forced install of weak-1.0.1. Thank you, @TooTallNate & @laverdet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is, I believe, the correct fix for #65, #66.
Error is very obvious while running node in debug mode. Line 140 will cause a crash because there's no HandleScope.