Downgrade electron-builder from 25.0.5 to 24.13.3 #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
deleted the
feature/downgrade-electron-builder-from-25.0.5-to-24.13.3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to solve the sporadic issue that
Error: Cannot find module 'jsonfile/utils'is emitted duringnpm run test:packageas seen in this build.A similar issue is reported in electron-userland/electron-builder#8503. In electron-userland/electron-builder#8503, several versions of electron-builder v25 are published/tested, but as of this writing (Oct. 16, 2024) it seems it's still work in progress with v25, so this PR reverts electron-builder to v24.
Setting
"notarize": falsein electron-builder.json comes from electron-userland/electron-builder#8103 (comment). Without"notarize": false, electron-builder tries to notarize this application, and there was an error like⨯ Cannot destructure property 'appBundleId' of 'options' as it is undefined..