Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix version switcher #1797

Merged
merged 4 commits into from
May 3, 2024
Merged

docs: fix version switcher #1797

merged 4 commits into from
May 3, 2024

Conversation

casperdcl
Copy link
Member

@casperdcl casperdcl commented Apr 30, 2024

Testing you performed

https://github.com/TomographicImaging/CIL/blob/fix-docs-version-switcher/.github/workflows/README.md#docs

Related issues/links

Checklist

  • I have performed a self-review of my code
  • I have added docstrings in line with the guidance in the developer guide
  • I have updated the relevant documentation
  • I have implemented unit tests that cover any new or modified functionality
  • CHANGELOG.md has been updated with any functionality change
  • Request review from all relevant developers
  • Change pull request label to 'Waiting for review'

Contribution Notes

Please read and adhere to the developer guide and local patterns and conventions.

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CIL (the Work) under the terms and conditions of the Apache-2.0 License
  • I confirm that the contribution does not violate any intellectual property rights of third parties

@casperdcl casperdcl mentioned this pull request Apr 30, 2024
16 tasks
@casperdcl casperdcl self-assigned this Apr 30, 2024
@casperdcl casperdcl requested review from paskino, lauramurgatroyd and a team April 30, 2024 14:23
@gfardell
Copy link
Member

gfardell commented May 1, 2024

How is it best to review this? Could you either add a screenshot to show functionality or maybe demo it in the stand-up?

@casperdcl casperdcl merged commit 31877b0 into master May 3, 2024
6 checks passed
@casperdcl casperdcl deleted the fix-docs-version-switcher branch May 3, 2024 11:01
@gfardell gfardell added this to the v24.1.0 milestone Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants