Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVRG and LSVRG approximate gradient methods #1625

Merged
merged 233 commits into from
Aug 19, 2024

Conversation

MargaretDuff
Copy link
Member

@MargaretDuff MargaretDuff commented Dec 14, 2023

Describe your changes

SVRG and LSVRG approximate gradient methods

Implements:
SVRG

LSVRG

Describe any testing you have performed

Please add any demo scripts to CIL-Demos/misc/

Link relevant issues

Closes #1623

Checklist when you are ready to request a review

  • I have performed a self-review of my code
  • I have added docstrings in line with the guidance in the developer guide
  • I have implemented unit tests that cover any new or modified functionality
  • CHANGELOG.md has been updated with any functionality change
  • Request review from all relevant developers
  • Change pull request label to 'Waiting for review'

Contribution Notes

Please read and adhere to the developer guide and local patterns and conventions.

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CIL (the Work) under the terms and conditions of the Apache-2.0 License.
  • I confirm that the contribution does not violate any intellectual property rights of third parties

Copy link
Contributor

@paskino paskino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it would be nice to add clearly in the documentation the memory requirements of these algorithms

@MargaretDuff
Copy link
Member Author

Jenkins is happy
image

@MargaretDuff MargaretDuff dismissed jakobsj’s stale review August 19, 2024 12:06

All comments outdated and checked with Jakob via discord

@MargaretDuff MargaretDuff merged commit 646264d into TomographicImaging:master Aug 19, 2024
8 checks passed
@MargaretDuff MargaretDuff deleted the svrg branch August 19, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: Needs reviewing
Status: PRs to review
Development

Successfully merging this pull request may close these issues.

Approximate gradients SVRG and LSVRG
7 participants