Remove the case of GetData in ProtocolHandlerMailbox#ShallDrop (neo-p…

…roject#1201)
Tommo-L · Jun 22, 2020 · c04de2a · c04de2a
1 parent dfe21c1
commit c04de2a
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 5 deletions.
diff --git a/neo.UnitTests/Network/P2P/UT_ProtocolHandlerMailbox.cs b/neo.UnitTests/Network/P2P/UT_ProtocolHandlerMailbox.cs
@@ -136,10 +136,6 @@ public void ProtocolHandlerMailbox_Test_ShallDrop()
             msg = Message.Create(MessageCommand.Inv, s);
             uut.ShallDrop(msg, emptyQueue).Should().Be(false);
             uut.ShallDrop(msg, new object[] { msg }).Should().Be(false);
-            // GetData (drop)
-            msg = Message.Create(MessageCommand.GetData, s);
-            uut.ShallDrop(msg, emptyQueue).Should().Be(false);
-            uut.ShallDrop(msg, new object[] { msg }).Should().Be(true);
             // NotFound (no drop)
             msg = Message.Create(MessageCommand.NotFound, s);
             uut.ShallDrop(msg, emptyQueue).Should().Be(false);

diff --git a/neo/Network/P2P/ProtocolHandler.cs b/neo/Network/P2P/ProtocolHandler.cs
@@ -329,7 +329,6 @@ internal protected override bool ShallDrop(object message, IEnumerable queue)
             {
                 case MessageCommand.GetAddr:
                 case MessageCommand.GetBlocks:
-                case MessageCommand.GetData:
                 case MessageCommand.GetHeaders:
                 case MessageCommand.Mempool:
                     return queue.OfType<Message>().Any(p => p.Command == msg.Command);