Skip to content

Commit

Permalink
Stabilize elastic-scaling pov-recovery test (paritytech#4958)
Browse files Browse the repository at this point in the history
Timing issues in container startup have made this test flaky. We now
wait for 20 and then register the parachain.
This makes sure that the parachain node has the ability to see all relay
chain notifications it needs.
  • Loading branch information
skunert authored and TomaszWaszczyk committed Jul 7, 2024
1 parent cc86e2c commit e11ecbe
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 6 deletions.
4 changes: 3 additions & 1 deletion cumulus/zombienet/tests/0002-pov_recovery.zndsl
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@ Description: PoV recovery test
Network: ./0002-pov_recovery.toml
Creds: config

# wait 20 blocks and register parachain
# Wait 20 blocks and register parachain. This part is important for pov-recovery.
# We need to make sure that the recovering node is able to see all relay-chain
# notifications containing the candidates to recover.
validator-3: reports block height is at least 20 within 250 seconds
validator-0: js-script ./register-para.js with "2000" within 240 seconds
validator-0: parachain 2000 is registered within 300 seconds
Expand Down
2 changes: 1 addition & 1 deletion cumulus/zombienet/tests/0009-elastic_pov_recovery.toml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ command = "polkadot"
[[parachains]]
id = 2100
chain = "elastic-scaling"
add_to_genesis = true
add_to_genesis = false

# Slot based authoring with 3 cores and 2s slot duration
[[parachains.collators]]
Expand Down
13 changes: 9 additions & 4 deletions cumulus/zombienet/tests/0009-elastic_pov_recovery.zndsl
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,17 @@ Creds: config
alice: is up
collator-elastic: is up

# wait 20 blocks and register parachain
# configure relay chain
alice: js-script ./assign-core.js with "2100,0" return is 0 within 200 seconds
alice: js-script ./assign-core.js with "2100,1" return is 0 within 200 seconds

# Wait 20 blocks and register parachain. This part is important for pov-recovery.
# We need to make sure that the recovering node is able to see all relay-chain
# notifications containing the candidates to recover.
alice: reports block height is at least 20 within 250 seconds
alice: js-script ./register-para.js with "2100" within 240 seconds
alice: parachain 2100 is registered within 300 seconds

# configure relay chain
alice: js-script ./assign-core.js with "2100,0" return is 0 within 600 seconds
alice: js-script ./assign-core.js with "2100,1" return is 0 within 600 seconds

# check block production
collator-elastic: reports block height is at least 40 within 225 seconds
Expand Down

0 comments on commit e11ecbe

Please sign in to comment.