TP-2126: Texts as props #1977
Merged
TP-2126: Texts as props #1977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roberdm49
requested review from
aguescribano87,
humbertodrc,
matiashernandev and
emanuelheredia
aguescribano87
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
TP-2126
Story
Refactor para aceptar ahora las traducciones por props.
Tests resolution
Investigando sobre el error de "TextEncoder is not defined", llegue a este hilo de github donde se discute acerca de problemas con la dependencia cheerio: enzymejs/enzyme#2518 (comment)
Aqui encontre una solucion fijando la version de esta dependencia, que causaba errores a mas de un usuario
Se adjunta tambien el resultado de npm ls cheerio, donde podemos observar que esta dependencia es solo de enzyme, por lo que no afectaria ningun flujo productivo.