feat: Add check that every declaration has a matching definition. #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-add-label
bot
added
the
enhancement
iphydf
force-pushed
the
decls-have-defns
branch
2 times, most recently
from
0f5ac4c
to
c724353
Compare
This avoids keeping function declarations around for which we deleted the implementation.
iphydf
force-pushed
the
decls-have-defns
branch
from
c724353
to
52c49dd
Compare
JFreegman
approved these changes
Dec 22, 2021
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids keeping function declarations around for which we deleted the
implementation.
This change is