feat: Require that for-init-decls have one of 2 formats. #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-add-label
bot
added
the
enhancement
JFreegman
approved these changes
Dec 15, 2021
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
iphydf
force-pushed
the
for-loops
branch
5 times, most recently
from
ebebff5
to
c63ac78
Compare
The for loop init decl should either be a variable declaration like `int i = 0` or an assignment like `i = 0`. This disallows for example `int i` as an init-decl (it's uninitialised) or some random other expression that's not an assignment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The for loop init decl should either be a variable declaration like
int i = 0or an assignment likei = 0. This disallows for exampleint ias an init-decl (it's uninitialised) or some random otherexpression that's not an assignment.
This change is