Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Remove language-c based style checker. #66

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Dec 6, 2021

We didn't use what this implemented, and what it did check isn't very
important. Cimple will do what C does, but better and with a much lighter
weight dependency.


This change is Reviewable

@iphydf iphydf added this to the v0.0.6 milestone Dec 6, 2021
@auto-add-label auto-add-label bot added the cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature. label Dec 6, 2021
Copy link
Member

@JFreegman JFreegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

We didn't use what this implemented, and what it did check isn't very
important. Cimple will do what C does, but better and with a much lighter
weight dependency.
@iphydf iphydf merged commit 503d1d0 into TokTok:master Dec 6, 2021
@iphydf iphydf deleted the rm-check-c branch December 6, 2021 17:27
@iphydf iphydf modified the milestones: v0.0.6, v0.0.7 Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants