Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add OPUS_SET_VBR, so we can disable it #254

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Conversation

Green-Sky
Copy link
Member

@Green-Sky Green-Sky commented Jul 1, 2024

This change is Reviewable

Copy link
Member

@nurupo nurupo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@Green-Sky
Copy link
Member Author

the code (cache?) server seems to be down

@nurupo
Copy link
Member

nurupo commented Jul 1, 2024

This bazel failure is @iphy's area of expertise.

I have looked into it myself, but I'm not sure why bazel fails. The cache seems to be up, I'm able to ping it on port 9092 via curl HTTP GET -- it returns some sort of a binary back, so the service is running. It's supposed to be gRPC instead of HTTP, so the binary output makes sense.

The "domain/ip:port" address format in the bazel exception output is kind of weird, if it was an HTTP GET, that would do a GET on /ip:port of the domain, but that could also be just how it prints out the address.

@iphydf
Copy link
Member

iphydf commented Jul 3, 2024

You can merge now. I've made bazel optional.

@Green-Sky Green-Sky merged commit 2ffe024 into master Jul 3, 2024
12 of 13 checks passed
@Green-Sky Green-Sky deleted the prep_opus_cbr branch July 3, 2024 17:25
@Green-Sky
Copy link
Member Author

merged, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants