Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add linter to detect sequences of #defines that should be enums. #221

Merged
merged 1 commit into from
Dec 21, 2023
Merged

feat: Add linter to detect sequences of #defines that should be enums. #221

merged 1 commit into from
Dec 21, 2023

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Dec 20, 2023 •
edited
Loading

This change is Reviewable

@iphydf iphydf added this to the v0.0.9 milestone Dec 20, 2023
@iphydf iphydf marked this pull request as ready for review December 20, 2023 17:11
JFreegman
JFreegman approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@JFreegman JFreegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@iphydf iphydf merged commit 1ae3935 into TokTok:master Dec 21, 2023
11 checks passed
@iphydf iphydf deleted the enum-defines branch December 21, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JFreegman JFreegman JFreegman approved these changes

Assignees

@iphydf iphydf

Labels
None yet
Projects
None yet
Milestone
v0.0.9
Development

Successfully merging this pull request may close these issues.
2 participants
@iphydf @JFreegman