Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/jshell rework #998

Merged
merged 10 commits into from
Feb 29, 2024
Merged

Feature/jshell rework #998

merged 10 commits into from
Feb 29, 2024

Conversation

Alathreon
Copy link
Contributor

No description provided.

@Alathreon Alathreon requested review from a team as code owners December 23, 2023 16:22
@Alathreon Alathreon linked an issue Dec 23, 2023 that may be closed by this pull request
Migrate JShell Bot #91
Closed
@marko-radosavljevic
Copy link
Contributor

Is this PR ready to be reviewed? Seems like a significant rework, based on the number of changes. It would probably help the review process if you gave some summary/outline of your PR.

And yeah, missing few curly boys, so sonar is mad at us: https://sonarcloud.io/project/issues?resolved=false&types=CODE_SMELL&sinceLeakPeriod=true&pullRequest=998&id=Together-Java_TJ-Bot ☺️

Thanks for your work, hopefully we will have jshell soon in prod. ❤️

@Alathreon
Copy link
Contributor Author

Is this PR ready to be reviewed? Seems like a significant rework, based on the number of changes. It would probably help the review process if you gave some summary/outline of your PR.

And yeah, missing few curly boys, so sonar is mad at us: https://sonarcloud.io/project/issues?resolved=false&types=CODE_SMELL&sinceLeakPeriod=true&pullRequest=998&id=Together-Java_TJ-Bot ☺️

Thanks for your work, hopefully we will have jshell soon in prod. ❤️

Oops sorry for the late response, yes it is ready for a review.
this PR does two things, it reworks jshell to supports the changes in the backend (support or multi snippets eval), and also big improvements of the display of the response of an eval.

marko-radosavljevic
marko-radosavljevic reviewed Jan 30, 2024
View reviewed changes
Copy link
Contributor

@marko-radosavljevic marko-radosavljevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't reviewed the new stuff, but changes are sensible, mostly a change to discord effective names instead of usernames.

Can you post some UI/UX pics?

application/src/main/java/org/togetherjava/tjbot/features/Features.java Outdated Show resolved Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/jshell/JShellCommand.java Outdated Show resolved Hide resolved
@Alathreon Alathreon force-pushed the feature/jshell branch 2 times, most recently from 6a9e30e to de176b0 Compare February 20, 2024 19:13
SquidXTV
SquidXTV previously approved these changes Feb 20, 2024
View reviewed changes
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Alathreon
Copy link
Contributor Author

Haven't reviewed the new stuff, but changes are sensible, mostly a change to discord effective names instead of usernames.

Can you post some UI/UX pics?

image
image
image

@marko-radosavljevic
Copy link
Contributor

Generally would like to see 2 reviews for a bigger feature like this. But the PR has been sitting for quite a while, and with 1 passing review… Let's ship it, and properly test it on development server. ❤️

I skimmed over it, and it seems fine. It's modular like all our futures, so if issues arise, we can always temporarily block it. ☺️

@marko-radosavljevic marko-radosavljevic merged commit ce95332 into develop Feb 29, 2024
10 checks passed
@marko-radosavljevic marko-radosavljevic deleted the feature/jshell branch February 29, 2024 19:37
Taz03 pushed a commit that referenced this pull request Mar 6, 2024
@Alathreon @SquidXTV @Taz03
Feature/jshell rework (#998)
74a4ad9 
* [Feature/JShell] Using the new reworked jshell api

* [Feature/JShell] Reworked renderer

* [feature/JShell] Running Spotless/Sonar

* [Feature/JShell] RenderResult deleted

* [Feature/JShell] Added doc on JShellEval

* [Feature/JShell] Added braces

* Rebase and rename user to member

* [Feature/JShell] Fixing checks

* [Feature/JShell] Fixing from some feedback

* [Feature/JShell] Replaced if elses with a switch thanks to java 21

---------

Co-authored-by: Connor Schweighoefer <[email protected]>
@ankitsmt211 ankitsmt211 mentioned this pull request Mar 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marko-radosavljevic marko-radosavljevic marko-radosavljevic left review comments

@SquidXTV SquidXTV SquidXTV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate JShell Bot
3 participants
@Alathreon @marko-radosavljevic @SquidXTV