Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove pinned eclipse jdt formatter Resolves #605 #1105

Merged

Conversation

thrashy
Copy link
Contributor

@thrashy thrashy commented May 7, 2024

Fix: Resolves #605

@thrashy thrashy requested a review from a team as a code owner May 7, 2024 02:46
@CLAassistant
Copy link

CLAassistant commented May 7, 2024

CLA assistant check
All committers have signed the CLA.

@ankitsmt211
Copy link
Member

@marko-radosavljevic you mind looking into the fix?

@marko-radosavljevic
Copy link
Contributor

Thanks for your first contribution @thrashy. Welcome to the project ☺️ ❤️

Not sure what introduced these changes, ideally upinning the formatter version doesn't change our formatting at all, but changes themselves are not bad. Finally unpinning the formatter has a lot of benefits on it's own, so I'm fine with it.

I just dislike incosistencies with formattig, and whole point of spotless automatization and formattig configuration was to have deterministic formatting, exactly how we want it, full cotrol to modify the behaviour. This is kinda not that, we just go with the flow what spotless spits out, because configuring it is not trivial.

Also not sure if it fixes the original reason we pinned the version in the first place, with that Token record, so our config might still have some issues. But that part of the codebase is refactored, so let's merge this and see how it goes.

@marko-radosavljevic marko-radosavljevic merged commit 9cf8944 into Together-Java:develop May 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update eclipse jdt formatter configuration
5 participants