Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: do not archive pinned threads (resolves #1084) #1088

Conversation

SimonVerhoeven
Copy link
Contributor

@SimonVerhoeven SimonVerhoeven commented Apr 14, 2024

This change moves the check a bit earlier, so the list is filtered in a functional style.
The change to the shouldBeArchived signature, is so isPinned() can be invoked.

fixes #1084

@SimonVerhoeven SimonVerhoeven requested a review from a team as a code owner April 14, 2024 08:52
@Taz03 Taz03 added bug Something isn't working priority: normal labels May 6, 2024
@tj-wazei tj-wazei merged commit 2738a98 into Together-Java:develop May 6, 2024
9 checks passed
@ankitsmt211 ankitsmt211 mentioned this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pinned threads should not be archived in questions
3 participants