Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed dismiss buttons #1065

Merged
merged 5 commits into from
Mar 22, 2024
Merged

fixed dismiss buttons #1065

merged 5 commits into from
Mar 22, 2024

Conversation

Taz03
Copy link
Member

@Taz03 Taz03 commented Mar 21, 2024

after the latest jda-upgrade, deleting self message gives "Unkown Webhook" Error, to fix we first need to defer reply to the event

replacing getMessage().delete() with deferEdit().deleteOriginal() in

  • Tex command
  • tags command
  • File Sharing Listener

@Taz03 Taz03 added bug Something isn't working priority: critical labels Mar 21, 2024
@Taz03 Taz03 self-assigned this Mar 21, 2024
@Taz03 Taz03 requested a review from a team as a code owner March 21, 2024 00:03
@ankitsmt211
Copy link
Member

could you brief what was the issue and how are we solving it? thanks

@Taz03
Copy link
Member Author

Taz03 commented Mar 21, 2024

@ankitsmt211 after the latest jda-upgrade, deleting self message gives "Unkown Webhook" Error, to fix we first need to defer reply to the event

@ankitsmt211
Copy link
Member

@Taz03 it seems getMessage.delete is present in other commands as well, assuming it would lead to issues there too?
some of the test cases also has it

couple of em i could find

  • tags command
  • Tex command
  • some tests around media listener/ above mentioned commands

@Taz03
Copy link
Member Author

Taz03 commented Mar 22, 2024

blocked by #1062

Copy link

sonarcloud bot commented Mar 22, 2024

Copy link
Member

@ankitsmt211 ankitsmt211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@ankitsmt211 ankitsmt211 merged commit b097708 into develop Mar 22, 2024
10 checks passed
@ankitsmt211 ankitsmt211 deleted the fix-dismiss-buttons branch March 22, 2024 16:07
@ankitsmt211 ankitsmt211 mentioned this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: critical
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants