Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formatted member count #1055

Merged
merged 1 commit into from
Mar 16, 2024
Merged

formatted member count #1055

merged 1 commit into from
Mar 16, 2024

Conversation

Taz03
Copy link
Member

@Taz03 Taz03 commented Mar 14, 2024 •
edited by ankitsmt211
Loading

  • Format member count with proper commas
  • For member count as 300000 it will be formatted to 300,000(groups of thousand).
  • update predicate to match category including commas in category name.

@Taz03 Taz03 self-assigned this Mar 14, 2024
@Taz03 Taz03 requested a review from a team as a code owner March 14, 2024 14:50
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

christolis
christolis approved these changes Mar 16, 2024
View reviewed changes
Copy link
Member

@christolis christolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Taz03 Taz03 merged commit 21df080 into develop Mar 16, 2024
10 checks passed
@Taz03 Taz03 deleted the fix-member-count branch March 16, 2024 20:32
@ankitsmt211 ankitsmt211 mentioned this pull request Mar 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitsmt211 ankitsmt211 ankitsmt211 left review comments

@tj-wazei tj-wazei tj-wazei approved these changes

@surajkumar surajkumar surajkumar approved these changes

@christolis christolis christolis approved these changes

Assignees

@Taz03 Taz03

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Taz03 @christolis @ankitsmt211 @surajkumar @tj-wazei