Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade jda #1031

Merged
merged 2 commits into from
Mar 16, 2024
Merged

upgrade jda #1031

merged 2 commits into from
Mar 16, 2024

Conversation

Taz03
Copy link
Member

@Taz03 Taz03 commented Feb 21, 2024 •
edited
Loading

  • upgrade jda
  • added new event forwards
  • updated code according to API changes
  • update UserInteractor interface to have empty default implementation
  • cat
    image

@Taz03 Taz03 requested review from a team as code owners February 21, 2024 17:41
@Taz03 Taz03 self-assigned this Feb 21, 2024
@Taz03
Copy link
Member Author

Taz03 commented Feb 21, 2024 •
edited
Loading

tests will pass after merging #1015

@Taz03 Taz03 marked this pull request as draft February 21, 2024 17:55
@Taz03
Copy link
Member Author

Taz03 commented Feb 21, 2024

need to merge #1016 to fix deprecated warnings

@Taz03 Taz03 marked this pull request as ready for review March 15, 2024 16:15
@Taz03 Taz03 force-pushed the upgrade-jda branch 3 times, most recently from a9fbeda to 3de5c6d Compare March 15, 2024 16:58
@tj-wazei tj-wazei force-pushed the upgrade-jda branch 2 times, most recently from fe52ec9 to 8967e53 Compare March 15, 2024 17:06
@Taz03 @SquidXTV @surajkumar
rebase
fa4f06c 
Co-authored-by: SquidXTV <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Taz03 Taz03 requested a review from SquidXTV March 16, 2024 09:58
@Taz03 Taz03 merged commit 4ff5966 into develop Mar 16, 2024
10 checks passed
@Taz03 Taz03 deleted the upgrade-jda branch March 16, 2024 23:15
@ankitsmt211 ankitsmt211 mentioned this pull request Mar 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SquidXTV SquidXTV SquidXTV approved these changes

@christolis christolis christolis approved these changes

Assignees

@Taz03 Taz03

@SquidXTV SquidXTV

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Taz03 @christolis @SquidXTV