Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add admin button to homepage and hamburger-menu #440

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

trstngttschlk
Copy link

@trstngttschlk trstngttschlk commented Aug 13, 2023

Description

  • added Admin button to homepage linking to adminDashboard
    • used FaUserShield as logo for Admin button
  • added Admin link to HamburgerNav linking to adminDashboard
  • added Admin button testing to landing.cy.js and tgt.js

Type of change

Please select everything applicable. Please, do not delete any lines.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change requires an update to testing

Issue

Checklist:

  • This PR is up to date with the main branch, and merge conflicts have been resolved
  • I have executed npm run test and all tests have passed successfully or I have included details within my PR on the failure.
  • I have executed npm run lint and resolved any outstanding errors. Most issues can be solved by executing npm run format
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@trstngttschlk trstngttschlk temporarily deployed to DEV August 13, 2023 13:43 — with GitHub Actions Inactive
@Caleb-Cohen
Copy link
Member

Howdy! Button looks great!

Everything looks good. One request. Can you add button testing to cypress/e2e/landing.cy.js?

I will want to merge this after we finish #439 so that users do not have access to the menu button.

@trstngttschlk
Copy link
Author

Hi Caleb,
Added testing for the new admin button.
Please let me know if any changes are needed.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a button to access the admin dashboard
2 participants