Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modified transform geom to accept arrays of geoms #811

Merged
merged 2 commits into from
Nov 5, 2019
Merged

modified transform geom to accept arrays of geoms #811

merged 2 commits into from
Nov 5, 2019

Conversation

snowman2
Copy link
Contributor

@snowman2 snowman2 commented Oct 24, 2019 •
edited
Loading

Closes #799

@snowman2 snowman2 mentioned this pull request Oct 24, 2019
Closed
sgillies
sgillies requested changes Oct 27, 2019
View reviewed changes
Copy link
Member

@sgillies sgillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snowman2 this looks right on track. Thank you. I left one comment and of course we will need tests.

@snowman2 snowman2 force-pushed the transform_array branch 2 times, most recently from 1ae3dcf to 51c349e Compare October 30, 2019 00:27
@snowman2 snowman2 marked this pull request as ready for review October 30, 2019 00:32
@snowman2
Copy link
Contributor Author

Not sure what is going on, but I see errors in the build like:

NOT using gdal 2.4.2 as expected;

@sgillies
Copy link
Member

sgillies commented Nov 4, 2019

@snowman2 oh dear, I think the maint-1.9 build is busted. I'm looking into it now.

@sgillies
Copy link
Member

sgillies commented Nov 5, 2019

Got the Travis build sorted out 🎉

sgillies
sgillies approved these changes Nov 5, 2019
View reviewed changes
Copy link
Member

@sgillies sgillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent.

@sgillies sgillies merged commit a7f7af0 into Toblerity:maint-1.9 Nov 5, 2019
@sgillies sgillies added this to the 1.9 milestone Nov 5, 2019
@snowman2
Copy link
Contributor Author

snowman2 commented Nov 5, 2019

Nice!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 83.285% when pulling 3da7b85 on snowman2:transform_array into 72e234d on Toblerity:maint-1.9.

snowman2 added a commit to snowman2/Fiona that referenced this pull request Apr 20, 2020
@snowman2
modified transform geom to accept arrays of geoms (Toblerity#811)
65e401e
@snowman2 snowman2 deleted the transform_array branch September 4, 2021 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgillies sgillies sgillies approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9
Development

Successfully merging this pull request may close these issues.
3 participants
@snowman2 @sgillies @coveralls