use _shim3.c for gdal >3.0 #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgillies
approved these changes
Oct 22, 2019
Closed
| @@ -261,7 +261,7 @@ def run(self): | |||
| log.info("Building Fiona for gdal 1.x: {0}".format(gdalversion)) | |||
| ext_modules.append( | |||
| Extension('fiona._shim', ['fiona/_shim1.c'], **ext_options)) | |||
| else: | |||
| elif gdal_minor_version == 2: | |||
There was a problem hiding this comment.
This needs to be gdal_major_version instead of gdal_minor_version I think
There was a problem hiding this comment.
oh no! yes, that was my mistake!
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use _shim3.c for gdal >= 3.0