Deprecate use of feature and geometry dicts #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And eliminate internal usage. All test modules with changes have been reformatted using black.
sgillies
commented
Jun 9, 2022
| if isinstance(obj, (int, float)): | ||
| return round(obj, precision) | ||
| else: | ||
| return [recursive_round(part, precision) for part in obj] |
There was a problem hiding this comment.
Replaces the previous rounding functions.
|
A trial merge (default) of this branch to master would have multiple simple conflicts in a number of files. Using |
|
setup.py gets messed up by |
|
The wheel builder is happy with d55b959 https://github.com/sgillies/fiona-wheels/actions/runs/2472175016. I'm going to merge this, tag 1.9a2, build wheels and release in the morning. |
This was referenced Jun 10, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And eliminate internal usage.
All test modules with changes have been reformatted using black. This was maybe misguided... I'll do a trial merge to the main branch and see what the impact is.