-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logic for using backup beacon nodes #56
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiWo
force-pushed
the
feature/add-backup-beacon-node
branch
from
September 14, 2023 14:29
28aabed
to
1dca486
Compare
Merged
LuisNaldo7
requested changes
Sep 21, 2023
TobiWo
force-pushed
the
feature/add-backup-beacon-node
branch
2 times, most recently
from
September 21, 2023 07:58
47d930d
to
8da1fdf
Compare
* Add beacon api healt endpoint * Add program constants for logging connection issues * Update logging messages * Add logging messages for beacon node connection issues
* Add new method for rest calls * Add beacon node connection logic
* Add no beacon node connection dto * Add max wait time for fetching duties * Add 503 response if wait time is exceeded
TobiWo
force-pushed
the
feature/add-backup-beacon-node
branch
from
September 21, 2023 08:33
8da1fdf
to
2c20351
Compare
LuisNaldo7
approved these changes
Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds functionality to use backup beacon nodes if provided. The underlying logic checks for the beacon node healthiness and uses the first healthy beacon node of the provided list.
In Detail this PR adds/changes:
--beacon-node
to--beacon-nodes
node1,node2,node3
:node1
will be used as long as there is no connection error to this particular nodenode2
will be used until there is a connection error to this particular nodeNote
Documentation will be updated in a separate PR since the next release will include multiple PRs
Closed issues
closes #27