Add comma separation for provided validators #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiWo
force-pushed
the
feature/add-comma-separation-for-provided-validators
branch
2 times, most recently
from
738ab70
to
921b88f
Compare
LuisNaldo7
previously approved these changes
Apr 19, 2023
TobiWo
force-pushed
the
feature/add-comma-separation-for-provided-validators
branch
from
921b88f
to
fea2bcb
Compare
* Add section where '--validators' is described in more detail * Update docker run examples
TobiWo
force-pushed
the
feature/add-comma-separation-for-provided-validators
branch
from
fea2bcb
to
0a8a5e8
Compare
LuisNaldo7
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introducing the possibility to provide multiple
--validatorsflags in v0.3.0 changed the general parsing behavior so that e.g. comma separation wasn't allowed anymore. Furthermore, the change introduced issues while working with compose files or other infrastructure as code tools like helm.This PR fixes the parsing issue through a simple own parsing implementation for the respective cli option. It changes the following aspects:
docker runexamples in the documentation were updated with an example how to provide a validator with an aliascomposewas updated because you can now add multiple validator identifiers on one lineCloses #39
Closes #38