Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework and add cli parameters #33

Merged
merged 7 commits into from
Mar 24, 2023
Merged

Rework and add cli parameters #33

merged 7 commits into from
Mar 24, 2023

Conversation

TobiWo
Copy link
Owner

@TobiWo TobiWo commented Mar 11, 2023 •
edited
Loading

Summary

This PRs reworks cli parameters in general and adds some more to eth-duties. In particular it includes the following changes:

  1. Delete cli flag shortcuts
  2. Renames --validator-file to --validators-file
  3. Adds --max-attestation-duty-logs which overrides the default of logging 50 attestation duties (if --omit-attestation-duties is not set)
  4. Adds --log-time-warning and --log-time-critical to customize thresholds for colorful logging
  5. Some smaller code refactorings

Closes #29

@TobiWo TobiWo added the enhancement New feature or request label Mar 11, 2023
@TobiWo TobiWo linked an issue Mar 11, 2023 that may be closed by this pull request
Add option to pass custom time spans for log coloring #29
Closed
@TobiWo TobiWo changed the title Feature/rework cli parameters Rework and add cli parameters Mar 11, 2023
@TobiWo TobiWo force-pushed the feature/rework-cli-parameters branch from 9d55e25 to 6b1f968 Compare March 18, 2023 13:22
@TobiWo
feat(cli): Rework cli
f0106c7 
* Refactor flags
* Delete shortcut flags
* Add customisable color logging thresholds
* Add flag max attestation duty log
@TobiWo
refactor(fetcher): Update attestation duty fetching logic
385d195
@TobiWo
refactor(logging): Update attestation duty logging logic
6cd3c63
@TobiWo TobiWo force-pushed the feature/rework-cli-parameters branch from 43bbce4 to afdcc71 Compare March 19, 2023 11:49
@TobiWo
docs(general): Update documentation
63bbf33 
* Delete 'todo' chapter
* Add 'donate' chapter
* Update usage for reworked cli
@TobiWo TobiWo force-pushed the feature/rework-cli-parameters branch from afdcc71 to 63bbf33 Compare March 19, 2023 12:07
@TobiWo TobiWo marked this pull request as ready for review March 19, 2023 12:08
@TobiWo TobiWo requested a review from LuisNaldo7 March 19, 2023 12:08
LuisNaldo7
LuisNaldo7 requested changes Mar 22, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@TobiWo TobiWo requested a review from LuisNaldo7 March 22, 2023 08:03
LuisNaldo7
LuisNaldo7 previously approved these changes Mar 22, 2023
View reviewed changes
@TobiWo TobiWo requested a review from LuisNaldo7 March 23, 2023 07:02
@TobiWo TobiWo merged commit 9ba3b5a into main Mar 24, 2023
@TobiWo TobiWo deleted the feature/rework-cli-parameters branch March 24, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuisNaldo7 LuisNaldo7 LuisNaldo7 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to pass custom time spans for log coloring
2 participants
@TobiWo @LuisNaldo7