Fix restriction that only 300 validators can be processed for sync committee duties #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiWo
changed the title
TobiWo
changed the title
TobiWo
force-pushed
the
feature/fix-300-validator-restriction
branch
2 times, most recently
from
e7f88fa
to
fea3cde
Compare
* Add new constants for validator parsing * Adapt validator count message constants * Add new program related constants for fetching and parsing validators
* Delete unnecessary separate fetch function * Refactor validator count function
TobiWo
force-pushed
the
feature/fix-300-validator-restriction
branch
from
fea3cde
to
65990ed
Compare
* Update for new api call functionality * Refactor for new constants
TobiWo
force-pushed
the
feature/fix-300-validator-restriction
branch
from
65990ed
to
67d9b32
Compare
LuisNaldo7
reviewed
Mar 10, 2023
LuisNaldo7
previously approved these changes
Mar 10, 2023
* Add update for consensus client compatibility * Updates todos * Update ToC
LuisNaldo7
approved these changes
Mar 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the restriction that only up to 300 validators could be fetched for attestation and sync committee duties. This was due to how much data you can send with the request to the beacon client.
However, to not pollute the screen with unnecessary attestation logs (e.g. for professional node operators) there is limit of 100 validators for which it is possible to log attestation duties. This behavior will be changed in a subsequent PR were new cli flags will be added (see this issue) and the remaining parameters will be reworked in general.
Further changes
Closes #16