Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge themebg into master to fix background option #58

Merged
merged 3 commits into from
Mar 6, 2019
Merged

Conversation

RedFantom
Copy link
Member

equilux_themebg
As shown in the image, the commits in this branch fix the usage of the background kwarg (renaming it to themebg to avoid confusion with the default background kwarg of Tk). In addition, the commits implement modified versions of the config, configure and cget functions to set and retrieve options. The custom options of ThemedTk can be set upon initialization, unlike the other options of Tk, but now also during run-time.

@Akuli
Copy link
Contributor

Akuli commented Mar 6, 2019

Does your config and cget stuff work with tkinter's widget['option'] syntax? I think I have tried to add my own options to widgets, and I also needed to override __setitem__ and __getitem__ to make it work. It might be easier to add the option with Tk instead of tkinter, if that's possible.

@RedFantom
Copy link
Member Author

You're right! Thank you for pointing that out, @Akuli .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants