Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

black theme: current notebook tab is same color as other tabs #46

Closed
Akuli opened this issue Aug 25, 2018 · 3 comments
Closed

black theme: current notebook tab is same color as other tabs #46

Akuli opened this issue Aug 25, 2018 · 3 comments
Assignees
@RedFantom
Labels
bug theme

Comments

@Akuli
Copy link
Contributor

Akuli commented Aug 25, 2018

aaaaa

It is very hard to tell which tab is selected. This is especially annoying because I have a ttk program that I use every day, and I really like the black theme otherwise.
@Akuli Akuli changed the title black theme: current treeview tab is same color as other tabs black theme: current notebook tab is same color as other tabs Aug 25, 2018
@RedFantom
Copy link
Member

For next time: These things may be reported in #44 .

This indeed looks like a serious UI issue. As black is based on clam, this might require more than just changing the background option of the Notebook.Tab style for the selected state.

@RedFantom RedFantom self-assigned this Aug 25, 2018
RedFantom added a commit that referenced this issue Sep 2, 2018
@RedFantom
Fix #46
d838048
@RedFantom
Copy link
Member

screenshot
What do you think?

@Akuli
Copy link
Contributor Author

Akuli commented Sep 3, 2018

This is awesome!

@RedFantom RedFantom mentioned this issue Sep 4, 2018
Merged
RedFantom added a commit that referenced this issue Sep 6, 2018
@RedFantom
Merge black into master to fix #46 with PR #47
20a2c81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RedFantom RedFantom

Labels
bug theme
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RedFantom @Akuli