Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Downgrade albumentations requirements #353

Merged
merged 2 commits into from
May 30, 2022

Conversation

shaneahmed
Copy link
Member

  • Downgrade albumentations requirement to 1.0.3 as the latest version didn't pass on conda feedstock.

- Downgrade albumentations requirement to 1.0.3 as the latest version didn't pass on conda feedstock.
@shaneahmed shaneahmed linked an issue May 30, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #353 (b7ea5d9) into develop (3a433e4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #353   +/-   ##
========================================
  Coverage    99.79%   99.79%           
========================================
  Files           54       54           
  Lines         5252     5252           
  Branches       913      913           
========================================
  Hits          5241     5241           
  Misses           4        4           
  Partials         7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a433e4...b7ea5d9. Read the comment docs.

@shaneahmed shaneahmed mentioned this pull request May 30, 2022
Copy link
Contributor

@DavidBAEpstein DavidBAEpstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

branch no longer exists, but requirements.dev.conda.yml will still fail.
I took the trouble of creating a file dev.err, which I included in Issue #352, which shows that requests is incorrectly spelled.

@shaneahmed
Copy link
Member Author

branch no longer exists, but requirements.dev.conda.yml will still fail. I took the trouble of creating a file dev.err, which I included in Issue #352, which shows that requests is incorrectly spelled.

Did you try this file https://github.com/TissueImageAnalytics/tiatoolbox/blob/dev-update-conda-albumentations/requirements.dev.conda.yml? What's the new error message?

- Fix requests in requirements file
@shaneahmed shaneahmed self-assigned this May 30, 2022
@shaneahmed shaneahmed requested a review from DavidBAEpstein May 30, 2022 13:07
@shaneahmed shaneahmed merged commit 1e808d3 into develop May 30, 2022
@shaneahmed shaneahmed deleted the dev-update-conda-albumentations branch May 30, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect requirements.dev.conda.yml
2 participants