Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aiofiles.os.path.islink function #126

Merged
merged 2 commits into from
Jan 8, 2022
Merged

Add aiofiles.os.path.islink function #126

merged 2 commits into from
Jan 8, 2022

Conversation

jpy-git
Copy link
Contributor

@jpy-git jpy-git commented Jan 7, 2022

This is the os.path equivalent of the symlink check introduced in #125

Docs: https://docs.python.org/3/library/os.path.html#os.path.islink

Added corresponding test.

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2022

Codecov Report

Merging #126 (9eb12e2) into master (313f4a5) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
+ Coverage   89.73%   89.80%   +0.06%     
==========================================
  Files          10       10              
  Lines         302      304       +2     
==========================================
+ Hits          271      273       +2     
  Misses         31       31              
Impacted Files Coverage Δ
src/aiofiles/ospath.py 100.00% <100.00%> (ø)
src/aiofiles/os.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 313f4a5...9eb12e2. Read the comment docs.

@Tinche
Copy link
Owner

Tinche commented Jan 7, 2022

Thanks!

Could you also update the docs for all of these too? Both the Usage section and the History section?

@jpy-git
Copy link
Contributor Author

jpy-git commented Jan 7, 2022

Could you also update the docs for all of these too? Both the Usage section and the History section?

Will do 😄

@jpy-git
Copy link
Contributor Author

jpy-git commented Jan 7, 2022

@Tinche I've updated the docs now. I put the new PRs under 0.9.0 (TBC) in History as a placeholder 😄

@Tinche
Copy link
Owner

Tinche commented Jan 8, 2022

Great, thanks!

@Tinche Tinche merged commit 00bf93d into Tinche:master Jan 8, 2022
@jpy-git jpy-git deleted the aiofiles.os.path.islink branch January 8, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants