remove transmute and fix rust warning #361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrosagg
force-pushed
the
remove-transmute
branch
2 times, most recently
from
11caa61
to
efc031b
Compare
while `()` is a ZST the potentially dangling reference is still undefined behaviour. Making it a static is a trivial fix. Signed-off-by: Petros Angelatos <[email protected]>
petrosagg
force-pushed
the
remove-transmute
branch
from
efc031b
to
cc64133
Compare
guswynn
reviewed
Mar 30, 2022
| @@ -650,7 +648,7 @@ where | |||
| type Storage = OrdKeyBatch<K, T, R, O>; | |||
|
|
|||
| fn key<'a>(&self, storage: &'a Self::Storage) -> &'a K { &self.cursor.key(&storage.layer) } | |||
| fn val<'a>(&self, _storage: &'a Self::Storage) -> &'a () { unsafe { ::std::mem::transmute(&self.empty) } } | |||
| fn val<'a>(&self, _storage: &'a Self::Storage) -> &'a () { &() } | |||
|
superseded by #367 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while
()is a ZST the potentially dangling reference is still undefined behaviour. Making it a static is a trivial fix.