count: add generic count_total_core method
#355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows the pattern of `distinct_core` to allow counting a collection but use a different diff type than `isize`. Signed-off-by: Petros Angelatos <[email protected]>
petrosagg
force-pushed
the
generic-count
branch
from
498d192
to
75bde6b
Compare
|
Looks good, tyvm! |
antiguru
pushed a commit
to antiguru/differential-dataflow
that referenced
this pull request
May 11, 2022
This follows the pattern of `distinct_core` to allow counting a collection but use a different diff type than `isize`. Signed-off-by: Petros Angelatos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the pattern of
distinct_coreto allow counting a collection but use a different diff type thanisize.