Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #268

Merged
merged 4 commits into from
Apr 18, 2020
Merged

Update README.md #268

merged 4 commits into from
Apr 18, 2020

Conversation

owenrh
Copy link
Contributor

@owenrh owenrh commented Apr 18, 2020

Code example was incorrect - has semi-colon instead of a dot.

Code example was incorrect - has semi-colon instead of a dot.
@frankmcsherry
Copy link
Member

Ah, wait! You are absolutely correct that the semicolon is wrong, but the dot is already on the next line! The right fix is just to drop the semicolon, I believe.

@frankmcsherry
Copy link
Member

Looks great!

@owenrh
Copy link
Contributor Author

owenrh commented Apr 18, 2020

Hmm, actually the code snippet is in the README twice, I only fixed it in one place. One secondo.

@owenrh
Copy link
Contributor Author

owenrh commented Apr 18, 2020

Patched the second example as well.

@frankmcsherry
Copy link
Member

Looks great; thanks very much for the attention to detail!

@frankmcsherry frankmcsherry merged commit 1a97786 into TimelyDataflow:master Apr 18, 2020
This was referenced Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants