Small stylistic change before release

TimVanMourik · Jul 24, 2017 · 8fefa5c · 8fefa5c
1 parent 850099e
commit 8fefa5c
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 10 deletions.
diff --git a/include/NodeTreeEditor/NodeTreeEditor.hpp b/include/NodeTreeEditor/NodeTreeEditor.hpp
@@ -29,8 +29,6 @@
 #include <QScrollArea>
 #include <QStandardItemModel>
 
-#include "Hider.hpp"
-
 class Node;
 class NodeTreeItem;
 class CodeEditor;

diff --git a/include/NodeTreeEditor/NodeTreeItem.hpp b/include/NodeTreeEditor/NodeTreeItem.hpp
@@ -26,8 +26,10 @@
 
 #include <QGraphicsPathItem>
 #include <QPoint>
+#include <QPushButton>
 #include <QStandardItem>
 #include <QFrame>
+#include <QUrl>
 
 class Node;
 class NodeSetting;
@@ -39,9 +41,6 @@ class QLabel;
 class QLineEdit;
 class QVBoxLayout;
 
-#include "Hider.hpp"
-
-#include <QPushButton>
 class NodeTreeItem : public QFrame
 {
     Q_OBJECT
@@ -114,6 +113,8 @@ public slots:
     //
     Node* m_node;
     //
+    QUrl m_url;
+    //
     QPoint m_startPosition;
     //
     QLabel* m_numberLabel;

diff --git a/resources/images/porcupine-walking.png b/resources/images/porcupine-walking.png
diff --git a/src/NodeTreeEditor/NodeTreeItem.cpp b/src/NodeTreeEditor/NodeTreeItem.cpp
@@ -48,6 +48,7 @@ NodeTreeItem::NodeTreeItem(
         ) :
     QFrame(_parent),
     m_node(_node),
+    m_url(m_node->getJson()["title"].toObject()["web_url"].toString()),
     m_startPosition(QPoint()),
     m_numberLabel(0),
     m_number(0),
@@ -87,8 +88,7 @@ NodeTreeItem::NodeTreeItem(
     headerLayout->addWidget(nameTag);
     connect(&m_node->getAntenna(), SIGNAL(nodeNameChanged(QString)), nameTag, SLOT(setText(QString)));
 
-    QString urlString = m_node->getJson()["title"].toObject()["web_url"].toString();
-    if(!urlString.isEmpty())
+    if(!m_url.isEmpty())
     {
         QPushButton* urlButton = new QPushButton();
         urlButton->setMaximumWidth(18);
@@ -172,9 +172,7 @@ void NodeTreeItem::saveToJson(
 void NodeTreeItem::openLink(
         )
 {
-    QString urlString = m_node->getJson()["title"].toObject()["web_url"].toString();
-    QUrl url(urlString);
-    QDesktopServices::openUrl(url);
+    QDesktopServices::openUrl(m_url);
 }
 
 void NodeTreeItem::mousePressEvent(