Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor meta_setup #13

Merged
merged 12 commits into from
Jun 8, 2021
Merged

Refactor meta_setup #13

merged 12 commits into from
Jun 8, 2021

Conversation

TimTeaFan
Copy link
Owner

This PR refactors meta_setup so that it doesn't use the parent environment to setup up calls, instead it uses a dedicated environment setup_env similar to dplyr's context environment.

This change entails some adjustment to the over-across functions and their tests.

TimTeaFan added 12 commits June 6, 2021 00:16
- refactored meta_setup to work in its own dedicated environment
- adjusted `over()` to work with new meta_setup.
adjusted switcher test to use ifelse instead of if_else.
- rewrote get data to work in encapsulated environment
- wipe setup_env on close of last dplyr call, instead of sys.frame(1L)
- commented out test of `local` which is working locally but not in testthat and reprex.
- fixed for across2 "recursive case" and "uses environment from current quosure"
- added nested case for crossover with tibble
@TimTeaFan TimTeaFan added this to the refactor `meta_setup ` milestone Jun 8, 2021
@TimTeaFan TimTeaFan merged commit 5026ccc into dev Jun 8, 2021
@TimTeaFan TimTeaFan linked an issue Jun 8, 2021 that may be closed by this pull request
@TimTeaFan TimTeaFan mentioned this pull request Jun 8, 2021
@TimTeaFan TimTeaFan deleted the new_metasetup branch September 26, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor meta_setup
1 participant