Refactor meta_setup
#13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nality to only check last verb.
- refactored meta_setup to work in its own dedicated environment - adjusted `over()` to work with new meta_setup.
adjusted switcher test to use ifelse instead of if_else.
- rewrote get data to work in encapsulated environment - wipe setup_env on close of last dplyr call, instead of sys.frame(1L)
- commented out test of `local` which is working locally but not in testthat and reprex. - fixed for across2 "recursive case" and "uses environment from current quosure" - added nested case for crossover with tibble
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
meta_setupso that it doesn't use the parent environment to setup up calls, instead it uses a dedicated environmentsetup_envsimilar to dplyr's context environment.This change entails some adjustment to the over-across functions and their tests.