-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tiledbsoma 1.6.0 pre-release check 1 #64
Conversation
…nda-forge-pinning 2023.12.01.08.31.55
@@ -86,17 +89,23 @@ outputs: | |||
- setuptools_scm | |||
- wheel | |||
- numpy | |||
- pyarrow | |||
# https://github.com/single-cell-data/TileDB-SOMA/issues/1926 | |||
- pyarrow <13.0 # [osx] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect that the error loading S3 objects described in single-cell-data/TileDB-SOMA#1926 (comment) is a runtime-only error. However, given the complexity of the libarrow run_exports, I agree it is safest to also enforce these pins at build time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jdblischak my thoughts exactly
This pre-check PR has green CI, which is its only job: |
I checked the build logs to confirm that:
Interestingly, for the linux builds (except py37), tiledbsoma-py was built against pyarrow <13, but then pyarrow 14.0.1 was installed at runtime. Thus the libarrow run_exports constraints might not be as strict as we had thought. My guess is that since we depend on pyarrow (and not directly on libarrow), that its |
As usual: https://github.com/single-cell-data/TileDB-SOMA/wiki/Branches-and-releases
except: single-cell-data/TileDB-SOMA#1926 (comment)
-- here we need to validate:
tiledb-py
0.24tiledb-r
0.22pyarrow
as noted in the linked issue aboveThere will be a
somacore
bump later, and anothertiledbsoma
PR, before 1.6.0 -- so there will be a second Conda pre-release-check PR, following on this one