Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiledbsoma 1.6.0 pre-release check 1 #64

Closed
wants to merge 5 commits into from

Conversation

johnkerl
Copy link
Collaborator

@johnkerl johnkerl commented Dec 1, 2023

As usual: https://github.com/single-cell-data/TileDB-SOMA/wiki/Branches-and-releases

except: single-cell-data/TileDB-SOMA#1926 (comment)

-- here we need to validate:

  • core 2.18
  • tiledb-py 0.24
  • tiledb-r 0.22
  • pyarrow as noted in the linked issue above

There will be a somacore bump later, and another tiledbsoma PR, before 1.6.0 -- so there will be a second Conda pre-release-check PR, following on this one

@johnkerl johnkerl changed the title Kerl/tiledbsoma 1.6.0 release check 1 tiledbsoma 1.6.0 pre-release check 1 Dec 1, 2023
@@ -86,17 +89,23 @@ outputs:
- setuptools_scm
- wheel
- numpy
- pyarrow
# https://github.com/single-cell-data/TileDB-SOMA/issues/1926
- pyarrow <13.0 # [osx]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that the error loading S3 objects described in single-cell-data/TileDB-SOMA#1926 (comment) is a runtime-only error. However, given the complexity of the libarrow run_exports, I agree it is safest to also enforce these pins at build time

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdblischak my thoughts exactly

@johnkerl
Copy link
Collaborator Author

johnkerl commented Dec 1, 2023

This pre-check PR has green CI, which is its only job:
https://github.com/single-cell-data/TileDB-SOMA/wiki/Branches-and-releases

@johnkerl johnkerl closed this Dec 1, 2023
@jdblischak
Copy link
Collaborator

I checked the build logs to confirm that:

  1. pyarrow < 13 was installed for the osx and osx-arm64 builds (typically pyarrow 11 or 12 was installed)
  2. pyarrow-hotfix was installed for all the builds

Interestingly, for the linux builds (except py37), tiledbsoma-py was built against pyarrow <13, but then pyarrow 14.0.1 was installed at runtime. Thus the libarrow run_exports constraints might not be as strict as we had thought. My guess is that since we depend on pyarrow (and not directly on libarrow), that its max_pin = "x" doesn't apply to tiledbsoma-py (to be clear, I don't think we need to change anything, just documenting the builds)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants