Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiledbsoma 1.9.1 pre-check #113

Closed
wants to merge 4 commits into from
Closed

tiledbsoma 1.9.1 pre-check #113

wants to merge 4 commits into from

Conversation

johnkerl
Copy link
Collaborator

Following our established procedure

jdblischak
jdblischak requested changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@jdblischak jdblischak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiledb pin needs bumped to 2.21

@johnkerl
Copy link
Collaborator Author

@jdblischak derp, I failed to apply the patch from #110 :|

@johnkerl johnkerl requested a review from jdblischak March 27, 2024 18:01
@johnkerl johnkerl force-pushed the kerl/tiledbsoma-1.9.1-pre-check branch from c916cc8 to 22e32c6 Compare March 27, 2024 18:05
jdblischak
jdblischak approved these changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@jdblischak jdblischak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-check approved

jdblischak
jdblischak requested changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@jdblischak jdblischak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait a second. It looks like you deleted all the CI files. Can you try rerendering again?

@johnkerl
Copy link
Collaborator Author

Sorry I was midway through a rerender & tabbed away -- just pushed the last commit ...

@johnkerl
Copy link
Collaborator Author

Closing per our established procedure

@johnkerl johnkerl closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdblischak jdblischak jdblischak approved these changes

@gspowley gspowley Awaiting requested review from gspowley gspowley will be requested when the pull request is marked ready for review gspowley is a code owner

@mlin mlin Awaiting requested review from mlin mlin will be requested when the pull request is marked ready for review mlin is a code owner

@Shelnutt2 Shelnutt2 Awaiting requested review from Shelnutt2 Shelnutt2 will be requested when the pull request is marked ready for review Shelnutt2 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnkerl @jdblischak