Add requested sizes to memory exceptions and logs. #5346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypatia
reviewed
Oct 11, 2024
shaunrd0
commented
Oct 14, 2024
| @@ -346,26 +346,83 @@ SparseGlobalOrderReader<BitmapType>::create_result_tiles( | |||
| // Get the number of fragments to process and compute per fragment memory. | |||
| uint64_t num_fragments_to_process = | |||
| tmp_read_state_.num_fragments_to_process(); | |||
| per_fragment_memory_ = memory_budget_.total_budget() * | |||
| memory_budget_.ratio_coords() / | |||
| num_fragments_to_process; | |||
There was a problem hiding this comment.
It looks like there was division by 0 happening here for the cases where num_fragments_to_process was found to be 0. The exception only came up after I introduced the coordinates_budget() method, but on rerunning the failing test I could see that we divide by zero without this method as well.
ypatia
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some more context to exceptions and logging when hitting cases where we have exceeded memory budgets.
TYPE: NO_HISTORY
DESC: Add requested sizes to memory exceptions and logs.