Reimplement C++ dump APIs as deprecated.
#5179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kounelisagis
force-pushed
the
agis/fix-dump-cpp-apis-missing
branch
from
d63cfb0
to
da48d7a
Compare
kounelisagis
force-pushed
the
agis/fix-dump-cpp-apis-missing
branch
from
da48d7a
to
fa37615
Compare
|
@eric-hughes-tiledb, @teo-tsirpanis I think every check will pass. Python and R are confirmed to have no problems on this branch. |
teo-tsirpanis
requested changes
Jul 11, 2024
This was referenced Jul 11, 2024
eric-hughes-tiledb
suggested changes
Jul 12, 2024
Comment on lines
31
to
32
| this_target_object_libraries(capi_string) | ||
| this_target_object_libraries(capi_dimension_stub) |
There was a problem hiding this comment.
FYI. this_target_object_libraries takes a list, not just a single argument.
|
Just wanted to note that eg |
Remove duplicate entry. Co-authored-by: Theodore Tsirpanis <[email protected]>
…DB_REMOVE_DEPRECATIONS`.
…ders and wrap them with `#ifndef TILEDB_REMOVE_DEPRECATIONS`.
eric-hughes-tiledb
suggested changes
Jul 18, 2024
teo-tsirpanis
force-pushed
the
agis/fix-dump-cpp-apis-missing
branch
from
ce7603a
to
0b0822c
Compare
KiterLuc
reviewed
Jul 18, 2024
KiterLuc
reviewed
Jul 18, 2024
KiterLuc
reviewed
Jul 18, 2024
teo-tsirpanis
approved these changes
Jul 18, 2024
eric-hughes-tiledb
approved these changes
Jul 18, 2024
| CHECK(rc == TILEDB_INVALID_CONTEXT); | ||
| } | ||
| SECTION("null domain") { | ||
| auto rc{tiledb_domain_dump(ctx, nullptr, nullptr)}; | ||
| tiledb_string_t* tdb_string; | ||
| auto rc{tiledb_domain_dump_str(ctx, nullptr, &tdb_string)}; | ||
| CHECK(rc == TILEDB_ERR); | ||
| } | ||
| // SECTION("null FILE") is omitted. Null FILE* defaults to stderr |
There was a problem hiding this comment.
It's no longer the case that null FILE * defaults to anything. This should be updated, but it's not critical to do so in this PR.
KiterLuc
changed the title
dump APIs as deprecateddump APIs as deprecated.
|
@eric-hughes-tiledb @KiterLuc @teo-tsirpanis thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[sc-32959]
Following #5026,
dumpC++ APIs were mistakenly deleted. This PR reimplements them as deprecated.operator<<remains the canonical interface.TYPE: NO_HISTORY
DESC: Reimplement
dumpC++ APIs as deprecated.