Implement bin partitioning function #5092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To write tiles into a temporary array that will fit into fixed-sized blocks on reading, this PR implements a bin partitioning function that returns a
std::vectorof cell partitions, such that each group of cells has a total byte count less than a specified number of bytes. Also returned is astd::vectorof the bin sizes (in number of bytes).This is the first file to go into the new sm/external_sort, so it also creates the directory and populates it with a test subdirectory and appropriate CMakeLists.txt files.
A previous PR creates a doc subdirectory and includes the svg image of our design for external sort.
[sc-48618]
TYPE: FEATURE
DESC: Implement a partitioning function to partition cells to fit into fixed size bins