Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable nightly testing of HDFS and log a warning when HDFS is enabled. #5085

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Disable nightly testing of HDFS and log a warning when HDFS is enabled. #5085

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
10fe421
Stop testing HDFS in nightlies.
teo-tsirpanis Jun 13, 2024
ecbe4c6
Add deprecation warning when configuring with HDFS enabled.
teo-tsirpanis Jun 13, 2024
687503a
Update BuildOptions.cmake
teo-tsirpanis Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/ci-linux_mac.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,11 @@ on:
description: 'CMake generator'
required: false
type: string
build_only:
default: false
description: 'Whether to only build TileDB and not run tests'
required: false
type: boolean

env:
BACKWARDS_COMPATIBILITY_ARRAYS: OFF
Expand Down Expand Up @@ -176,6 +181,7 @@ jobs:

- name: 'Test libtiledb'
id: test
if: ${{ !inputs.build_only }}
shell: bash
env:
ASAN_OPTIONS: ${{ inputs.asan && 'detect_leaks=0' || '' }}
Expand Down Expand Up @@ -266,6 +272,7 @@ jobs:
/cores/

- name: 'Test status check'
if: ${{ !inputs.build_only }}
run: |
# tiledb_unit is configured to set a variable TILEDB_CI_SUCCESS=1
# following the test run. If this variable is not set, the build should fail.
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/nightly-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,14 +65,15 @@ jobs:
run: |
cmake --build build --target check --config ${{ matrix.config || 'Release' }}

test_hdfs:
test_hdfs_build:
uses: ./.github/workflows/ci-linux_mac.yml
with:
ci_backend: HDFS
matrix_image: ubuntu-24.04
matrix_compiler_cc: 'gcc-13'
matrix_compiler_cxx: 'g++-13'
timeout: 300
build_only: true
bootstrap_args: '--enable-hdfs --enable-static-tiledb --disable-werror'

create_issue_on_fail:
Expand All @@ -81,7 +82,7 @@ jobs:
runs-on: ubuntu-latest
needs:
- test
- test_hdfs
- test_hdfs_build
if: failure() || cancelled()
steps:
- name: Checkout TileDB `dev`
Expand Down
4 changes: 4 additions & 0 deletions cmake/Options/BuildOptions.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ if (NOT TILEDB_VCPKG)
message(FATAL_ERROR "Disabling TILEDB_VCPKG is not supported. To disable automatically downloading vcpkg, enable the TILEDB_DISABLE_AUTO_VCPKG option, or set ENV{TILEDB_DISABLE_AUTO_VCPKG} to any value.")
endif()

if (TILEDB_HDFS)
message(DEPRECATION "The HDFS storage backend is deprecated and untested. It will be removed in TileDB 2.28.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's mention that we only test that it builds.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

endif()

# enable assertions by default for debug builds
if (CMAKE_BUILD_TYPE STREQUAL "Debug")
set(TILEDB_ASSERTIONS TRUE)
Expand Down
Loading