-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Status_StorageManagerError and Migrate group_metadata_vacuum out of StorageManager. #5034
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change for which exception to throw needed.
Also, we should make stories for removal of StorageManager
for (1) class Array
and (2) Consolidator::create
.
tiledb/sm/group/group.cc
Outdated
throw GroupException("Cannot vacuum group metadata; Group does not exist"); | ||
} | ||
|
||
StorageManager storage_manager(resources, resources.logger(), config); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needing to make a new storage manager just to call Consolidator::create
is quite a red flag. The problem isn't in this code narrowly, though; it's the implementation of the consolidator.
We should target changing Consolidator::create
for a refactor. It should be possible to convert it to ContextResources
and RestClient
, but it will also entail changing a constructor signature for Array
. It's definitely going to require a concerted effort. Removing all the array and group functions from StorageManager
should happen first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's already a followup story to remove usage of StorageManager
from the consolidation code: https://app.shortcut.com/tiledb-inc/story/47947/eliminate-storagemanager-arguments-in-consolidation-code-in-favor-of-contextresources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1e06ea7
to
2b96634
Compare
0267a8c
to
b402392
Compare
Merging with the unit URI failures as they are unrelated. [sc-https://app.shortcut.com/tiledb-inc/story/48975/intermittent-segfaults-in-unit-uri-on-windows] |
Remove
Status_StorageManagerError
and its occurrences.Related subsequent fixes:
Logger::status_no_return_value
and replace occurrences withLogger::error
.Status
andstd::optional
from returned tuple ofArray::open_for_writes
.Status
Context::init_loggers
.StorageManagerCanonical::group_metadata_vacuum
->static Group::vacuum_metadata
.[sc-48630]
[sc-48639]
TYPE: NO_HISTORY
DESC: Remove
Status_StorageManagerError
and Migrategroup_metadata_vacuum
out ofStorageManager
.