-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for partial tile offsets loading. #5004
Merged
KiterLuc
merged 3 commits into
dev
from
dstara/add_tests_for_partial_tile_offsets_loading
Jun 6, 2024
Merged
Add tests for partial tile offsets loading. #5004
KiterLuc
merged 3 commits into
dev
from
dstara/add_tests_for_partial_tile_offsets_loading
Jun 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitrisStaratzis
force-pushed
the
dstara/add_tests_for_partial_tile_offsets_loading
branch
from
May 23, 2024 17:14
304fffc
to
19e3082
Compare
KiterLuc
changed the title
add tests for partial tile offsets loading
Add tests for partial tile offsets loading.
May 23, 2024
DimitrisStaratzis
force-pushed
the
dstara/add_tests_for_partial_tile_offsets_loading
branch
from
May 27, 2024 18:29
9d83310
to
8ba172d
Compare
DimitrisStaratzis
changed the title
Add tests for partial tile offsets loading.
WIP Add tests for partial tile offsets loading.
May 27, 2024
DimitrisStaratzis
force-pushed
the
dstara/add_tests_for_partial_tile_offsets_loading
branch
3 times, most recently
from
May 28, 2024 16:17
c50bec2
to
19c0a76
Compare
DimitrisStaratzis
changed the title
WIP Add tests for partial tile offsets loading.
Add tests for partial tile offsets loading.
May 28, 2024
That’s ready to go @KiterLuc |
ypatia
reviewed
May 29, 2024
"[sparse-unordered-with-dups][tile-offsets][multiple-iterations]") { | ||
bool set_subarray = GENERATE(true, false); | ||
"Sparse unordered with dups reader: tile offsets partial loading", | ||
"[sparse-unordered-with-dups][tile-offsets][multiple-iterations][dstara]") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove [dstara]
tag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. Done!
DimitrisStaratzis
force-pushed
the
dstara/add_tests_for_partial_tile_offsets_loading
branch
from
May 29, 2024 11:17
19c0a76
to
1a17dae
Compare
DimitrisStaratzis
force-pushed
the
dstara/add_tests_for_partial_tile_offsets_loading
branch
from
June 4, 2024 11:07
e340c27
to
93275e7
Compare
KiterLuc
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding complete tests for the partial tile offset loading feature. Remodeled one of the existing tests
[sc-46969]
TYPE: NO_HISTORY
DESC: Add tests for partial tile offsets loading.