Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for partial tile offsets loading. #5004

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

DimitrisStaratzis
Copy link
Contributor

@DimitrisStaratzis DimitrisStaratzis commented May 23, 2024

Adding complete tests for the partial tile offset loading feature. Remodeled one of the existing tests

[sc-46969]


TYPE: NO_HISTORY
DESC: Add tests for partial tile offsets loading.

@DimitrisStaratzis DimitrisStaratzis force-pushed the dstara/add_tests_for_partial_tile_offsets_loading branch from 304fffc to 19e3082 Compare May 23, 2024 17:14
@KiterLuc KiterLuc changed the title add tests for partial tile offsets loading Add tests for partial tile offsets loading. May 23, 2024
@DimitrisStaratzis DimitrisStaratzis force-pushed the dstara/add_tests_for_partial_tile_offsets_loading branch from 9d83310 to 8ba172d Compare May 27, 2024 18:29
@DimitrisStaratzis DimitrisStaratzis marked this pull request as draft May 27, 2024 19:51
@DimitrisStaratzis DimitrisStaratzis changed the title Add tests for partial tile offsets loading. WIP Add tests for partial tile offsets loading. May 27, 2024
@DimitrisStaratzis DimitrisStaratzis force-pushed the dstara/add_tests_for_partial_tile_offsets_loading branch 3 times, most recently from c50bec2 to 19c0a76 Compare May 28, 2024 16:17
@DimitrisStaratzis
Copy link
Contributor Author

@DimitrisStaratzis DimitrisStaratzis marked this pull request as ready for review May 28, 2024 20:11
@DimitrisStaratzis DimitrisStaratzis changed the title WIP Add tests for partial tile offsets loading. Add tests for partial tile offsets loading. May 28, 2024
@DimitrisStaratzis
Copy link
Contributor Author

That’s ready to go @KiterLuc

"[sparse-unordered-with-dups][tile-offsets][multiple-iterations]") {
bool set_subarray = GENERATE(true, false);
"Sparse unordered with dups reader: tile offsets partial loading",
"[sparse-unordered-with-dups][tile-offsets][multiple-iterations][dstara]") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove [dstara] tag

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Done!

@DimitrisStaratzis DimitrisStaratzis force-pushed the dstara/add_tests_for_partial_tile_offsets_loading branch from 19c0a76 to 1a17dae Compare May 29, 2024 11:17
@DimitrisStaratzis DimitrisStaratzis force-pushed the dstara/add_tests_for_partial_tile_offsets_loading branch from e340c27 to 93275e7 Compare June 4, 2024 11:07
@KiterLuc KiterLuc merged commit bc4ec51 into dev Jun 6, 2024
60 checks passed
@KiterLuc KiterLuc deleted the dstara/add_tests_for_partial_tile_offsets_loading branch June 6, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants