Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidation plan REST support - part1: handler #4534

Merged
merged 6 commits into from
Nov 30, 2023

Conversation

ypatia
Copy link
Member

@ypatia ypatia commented Nov 23, 2023

This is adding support for serializing the Consolidation Plan via REST, in order to make it usable with TileDB Cloud.
This first part is adding the C-API handler Cloud needs to call from Go to implement this feature. Part 2 that integrates with the rest client will follow as a separate PR.

Design doc: https://www.notion.so/Consolidation-Plan-Request-Handler-d25fb00674444bcdaed74a8e46761b97


TYPE: IMPROVEMENT
DESC: Consolidation plan REST support - part1: handler

Copy link

This pull request has been linked to Shortcut Story #25420: [core-rest] Cloud support for consolidation plan API.

@ypatia ypatia requested review from KiterLuc and davisp November 23, 2023 15:28
Copy link
Contributor

@davisp davisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Design doc looks good.
  • APIs added match the design doc.
  • Tests look good.

+1

@KiterLuc KiterLuc merged commit e1929ed into dev Nov 30, 2023
60 checks passed
@KiterLuc KiterLuc deleted the yt/sc-25420/rest_support_consolidation_plan branch November 30, 2023 08:37
KiterLuc pushed a commit that referenced this pull request Mar 12, 2024
This is part2 of #4534 , adding
the `rest_client` part.

---
TYPE: FEATURE
DESC: Consolidation Plan REST support - part 2: rest client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants