Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tests against hidden libwebp symbols in link_webp_test1.cc #4525

Merged
merged 5 commits into from
Nov 20, 2023
Merged

Remove tests against hidden libwebp symbols in link_webp_test1.cc #4525

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
72ad8b3
Remove tests against hidden libwebp symbols in link_webp_test1.cc
valgur Nov 19, 2023
594b4e8
Also remove usage of internal symbols in link_webp_test1.cc
valgur Nov 19, 2023
85534e4
Remove unused variables in link_webp_test1.cc
valgur Nov 19, 2023
12a6a56
Remove remaining WebP function declarations
valgur Nov 20, 2023
0ee17bf
Fix compile errors.
teo-tsirpanis Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions tiledb/sm/compressors/test/link_webp_test1.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,15 +98,7 @@ uint64_t reference_a_value(uint64_t v) {

extern "C" int WebPGetDemuxVersion(void);
extern "C" int WebPGetMuxVersion(void);
extern "C" VP8StatusCode WebPAllocateDecBuffer(
int width,
int height,
const WebPDecoderOptions* const options,
WebPDecBuffer* const buffer);
extern "C" void WebPFreeDecBuffer(WebPDecBuffer* const buffer);
valgur marked this conversation as resolved.
Show resolved Hide resolved
typedef void VP8LDecoder;
extern "C" VP8LDecoder* VP8LNew(void);
extern "C" void VP8LClear(VP8LDecoder*);

int main(int argc, const char* argv[]) {
int return_value = -1;
Expand Down Expand Up @@ -138,16 +130,6 @@ int main(int argc, const char* argv[]) {
// *** turns out, there is -NO- symbol in webpdecoder that is not also in
// webp! left here anyway, in case libraries are ever de-dupped.
const int dec_version = WebPGetDecoderVersion();
auto vp8l_dec = VP8LNew();
VP8LClear(vp8l_dec);

VP8StatusCode status;
WebPDecoderOptions webpdecoptions;
WebPDecBuffer webpdec_buffer;
status = WebPAllocateDecBuffer(512, 512, &webpdecoptions, &webpdec_buffer);
if (status == VP8_STATUS_OK) {
WebPFreeDecBuffer(&webpdec_buffer);
}

// webpdemux
const int demux_version = WebPGetDemuxVersion();
Expand Down
Loading