-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the manylinux CI job to GitHub Actions. #4491
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teo-tsirpanis
force-pushed
the
gha-azdo-manylinux
branch
from
November 6, 2023 12:38
c56d3b3
to
0b13442
Compare
teo-tsirpanis
force-pushed
the
gha-azdo-manylinux
branch
2 times, most recently
from
November 6, 2023 14:54
0533fa7
to
0497954
Compare
teo-tsirpanis
force-pushed
the
gha-azdo-manylinux
branch
from
November 6, 2023 16:08
050e957
to
1099bea
Compare
teo-tsirpanis
changed the title
[WIP] Move the manylinux CI job to GitHub Actions.
Move the manylinux CI job to GitHub Actions.
Nov 6, 2023
ihnorton
reviewed
Nov 7, 2023
teo-tsirpanis
force-pushed
the
gha-azdo-manylinux
branch
2 times, most recently
from
November 7, 2023 15:30
44d6d7c
to
e89e593
Compare
teo-tsirpanis
force-pushed
the
gha-azdo-manylinux
branch
from
November 7, 2023 16:16
e89e593
to
5d6ba20
Compare
teo-tsirpanis
force-pushed
the
gha-azdo-manylinux
branch
from
November 13, 2023 12:22
e767149
to
97cd522
Compare
@KiterLuc the write failure test has been skipped on Manylinux and CI is green. |
KiterLuc
reviewed
Nov 16, 2023
@@ -713,6 +714,10 @@ TEST_CASE_METHOD( | |||
// DenyWriteAccess is not supported on Windows. | |||
if constexpr (tiledb::platform::is_os_windows) | |||
return; | |||
// The test fails on Manylinux. Skip it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File a shortcut story to remove this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened SC-37093.
KiterLuc
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the last CI job moves off Azure DevOps.
TYPE: NO_HISTORY