Group metadata doesn't get serialized #3147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiterLuc
suggested changes
May 9, 2022
KiterLuc
approved these changes
May 10, 2022
ihnorton
approved these changes
May 10, 2022
|
I believe Cloud team has worked around this issue for now, converting to draft pending further discussion with @Shelnutt2. |
robertbindar
force-pushed
the
rbin/group_serialize_bug
branch
from
e871744 to
d8f2293
Compare
KiterLuc
reviewed
Oct 31, 2023
KiterLuc
reviewed
Oct 31, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
As @snagles reported, the group metadata seems to be written correctly, but it's empty when you try to read it. I managed to reproduce it locally by opening a TileDB Cloud group, then created a test for it by serializing-deserializing a group with metadata locally. The serialization code is calling `Group::metadata()` to get the md object, but the `Metadata` content is not brought up from disk, so the group looks like it has no metadata. `Group::load_metadata` needs to be called to make sure we serialize a synced version of `Metadata`. --- TYPE: BUG DESC: Group metadata doesn't get serialized --------- Co-authored-by: KiterLuc <[email protected]> (cherry picked from commit 71a2cc4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @snagles reported, the group metadata seems to be written correctly, but it's empty when you try to read it.
I managed to reproduce it locally by opening a TileDB Cloud group, then created a test for it by serializing-deserializing a group with metadata locally.
The serialization code is calling
Group::metadata()to get the md object, but theMetadatacontent is not brought up from disk, so the group looks like it has no metadata.Group::load_metadataneeds to be called to make sure we serialize a synced version ofMetadata.TYPE: BUG
DESC: Group metadata doesn't get serialized