Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression test target; Test and fix for SC-17415 #3143

Merged
merged 3 commits into from
May 5, 2022

Conversation

ihnorton
Copy link
Member

@ihnorton ihnorton commented May 4, 2022

  • Add tiledb_regression test target
  • Regression test for SC-17415
  • Fix for SC-17415: avoid segfault due to underflow in for loop

TYPE: IMPROVEMENT
DESC: Add tiledb_regression test target

TYPE: BUG
DESC: Fix SC-17415: segfault due to underflow in for loop

@ihnorton ihnorton requested review from johnkerl and KiterLuc May 4, 2022 21:20
@shortcut-integration
Copy link

Copy link
Contributor

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

tiledb/sm/misc/comparators.h Outdated Show resolved Hide resolved
tiledb/sm/misc/comparators.h Outdated Show resolved Hide resolved
test/regression/targets/sc-15387.cc Show resolved Hide resolved
@ihnorton ihnorton force-pushed the ihn/sc-15387+sc-17415 branch 2 times, most recently from 151a7f0 to 536c982 Compare May 5, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants