Percent-encode reserved characters in file names #2047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stavrospapadopoulos
approved these changes
Jan 26, 2021
joe-maley
force-pushed
the
jpm/encode-attr-dim-names
branch
2 times, most recently
from
7fa2199 to
5defb05
Compare
ihnorton
approved these changes
Jan 27, 2021
This bumps the format version from 7 to 8. For version 8, dimension and attribute names are percent-encoded to RFC 3986 + a few extra to handle reserved characters on Windows. This is intended to be a temporary measure. In the future, we will include a mapping between names and their ordered index in the array schema.
joe-maley
force-pushed
the
jpm/encode-attr-dim-names
branch
from
5defb05 to
412a9e9
Compare
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-2.2 release-2.2
# Navigate to the new working tree
cd .worktrees/backport-release-2.2
# Create a new branch
git switch --create backport-2047-to-release-2.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick ---mainline 1 97c5c4b0aa35cfd96197558ffc1189860b4adc6f
# Push it to GitHub
git push --set-upstream origin backport-2047-to-release-2.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-2.2Then, create a pull request where the |
joe-maley
pushed a commit
that referenced
this pull request
Jan 27, 2021
This bumps the format version from 7 to 8. For version 8, dimension and attribute names are percent-encoded to RFC 3986 + a few extra to handle reserved characters on Windows. This is intended to be a temporary measure. In the future, we will include a mapping between names and their ordered index in the array schema. Co-authored-by: Joe Maley <[email protected]>
Shelnutt2
pushed a commit
that referenced
this pull request
Jan 27, 2021
This bumps the format version from 7 to 8. For version 8, dimension and attribute names are percent-encoded to RFC 3986 + a few extra to handle reserved characters on Windows. This is intended to be a temporary measure. In the future, we will include a mapping between names and their ordered index in the array schema. Co-authored-by: Joe Maley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps the format version from 7 to 8. For version 8, dimension and
attribute names are percent-encoded to RFC 3986 + a few extra to handle
reserved characters on Windows.
This is intended to be a temporary measure. In the future, we will include
a mapping between names and their ordered index in the array schema.